Commit 1d1ef005 authored Jul 05, 2018 by John Fastabend Committed by Alexei Starovoitov Jul 07, 2018

bpf: sockmap, hash table is RCU so readers do not need locks



This removes locking from readers of RCU hash table. Its not
necessary.

Fixes: 81110384 ("bpf: sockmap, add hash map support")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

parent 547b3aa4

kernel/bpf/sockmap.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2467,10 +2467,8 @@ struct sock __sock_hash_lookup_elem(struct bpf_map map, void *key)
		b = __select_bucket(htab, hash);
		head = &b->head;

		raw_spin_lock_bh(&b->lock);
		l = lookup_elem_raw(head, hash, key, key_size);
		sk = l ? l->sk : NULL;
		raw_spin_unlock_bh(&b->lock);
		return sk;
		}