Commit 1cd70d84 authored Jan 18, 2023 by Alexey V. Vissarionov Committed by Greg Kroah-Hartman Feb 06, 2023

scsi: hpsa: Fix allocation size for scsi_host_alloc()

[ Upstream commit bbbd25499100c810ceaf5193c3cfcab9f7402a33 ]

The 'h' is a pointer to struct ctlr_info, so it's just 4 or 8 bytes, while
the structure itself is much bigger.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: edd16368 ("hpsa: add driver for HP Smart Array controllers.")
Link: https://lore.kernel.org/r/20230118031255.GE15213@altlinux.org


Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>
Acked-by: Don Brace <don.brace@microchip.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4d55f918

drivers/scsi/hpsa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5810,7 +5810,7 @@ static int hpsa_scsi_host_alloc(struct ctlr_info *h)
		{
		struct Scsi_Host *sh;

		sh = scsi_host_alloc(&hpsa_driver_template, sizeof(h));
		sh = scsi_host_alloc(&hpsa_driver_template, sizeof(struct ctlr_info));
		if (sh == NULL) {
		dev_err(&h->pdev->dev, "scsi_host_alloc failed\n");
		return -ENOMEM;