Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cc9fc53 authored by Alexander Aring's avatar Alexander Aring Committed by David S. Miller
Browse files

at86rf230: remove unnecessary state read 



This patch removes a unnecessary state read. The status value is never
evaluate after reading the state.

Also rename the status variable to dvdd, because this variable will be
used later.

Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57e48ffc

drivers/net/ieee802154/at86rf230.c

+3 −7
Original line number Diff line number Diff line
@@ -969,13 +969,9 @@ static int at86rf230_irq_polarity(struct at86rf230_local *lp, int pol) 
static int at86rf230_hw_init(struct at86rf230_local *lp)

{

	int rc, irq_pol, irq_type;

	u8 status;

	u8 dvdd;

	u8 csma_seed[2];



	rc = at86rf230_read_subreg(lp, SR_TRX_STATUS, &status);

	if (rc)

		return rc;



	rc = at86rf230_write_subreg(lp, SR_TRX_CMD, STATE_FORCE_TRX_OFF);

	if (rc)

		return rc;
@@ -1015,10 +1011,10 @@ static int at86rf230_hw_init(struct at86rf230_local *lp) 
	/* Wait the next SLEEP cycle */

	msleep(100);



	rc = at86rf230_read_subreg(lp, SR_DVDD_OK, &status);

	rc = at86rf230_read_subreg(lp, SR_DVDD_OK, &dvdd);

	if (rc)

		return rc;

	if (!status) {

	if (!dvdd) {

		dev_err(&lp->spi->dev, "DVDD error\n");

		return -EINVAL;

	}