Commit 1cbe866c authored Oct 02, 2019 by Mohamad Heib Committed by Jason Gunthorpe Oct 04, 2019

IB/core: Fix wrong iterating on ports

rdma_for_each_port is already incrementing the iterator's value it
receives therefore, after the first iteration the iterator is increased by
2 which eventually causing wrong queries and possible traces.

Fix the above by removing the old redundant incrementation that was used
before rdma_for_each_port() macro.

Cc: <stable@vger.kernel.org>
Fixes: ea1075ed ("RDMA: Add and use rdma_for_each_port")
Link: https://lore.kernel.org/r/20191002122127.17571-1-leon@kernel.org


Signed-off-by: Mohamad Heib <mohamadh@mellanox.com>
Reviewed-by: Erez Alfasi <ereza@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 594e6c5d

drivers/infiniband/core/security.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -426,7 +426,7 @@ int ib_create_qp_security(struct ib_qp qp, struct ib_device dev)
		int ret;

		rdma_for_each_port (dev, i) {
		is_ib = rdma_protocol_ib(dev, i++);
		is_ib = rdma_protocol_ib(dev, i);
		if (is_ib)
		break;
		}