Commit 1bfaac7c authored Jul 31, 2019 by Pascal van Leeuwen Committed by Herbert Xu Aug 09, 2019

crypto: inside-secure - Remove redundant DES ECB & CBC keysize check

This patch removes a DES key size check that is redundant as it is already
performed by the crypto API itself due to min_keysize = max_keysize.

Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Acked-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 114e2ccd

drivers/crypto/inside-secure/safexcel_cipher.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1197,11 +1197,6 @@ static int safexcel_des_setkey(struct crypto_skcipher ctfm, const u8 key,
		u32 tmp[DES_EXPKEY_WORDS];
		int ret;

		if (len != DES_KEY_SIZE) {
		crypto_skcipher_set_flags(ctfm, CRYPTO_TFM_RES_BAD_KEY_LEN);
		return -EINVAL;
		}

		ret = des_ekey(tmp, key);
		if (!ret && (tfm->crt_flags & CRYPTO_TFM_REQ_FORBID_WEAK_KEYS)) {
		tfm->crt_flags \|= CRYPTO_TFM_RES_WEAK_KEY;