Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1bba6de1 authored by Yang Wei's avatar Yang Wei Committed by David S. Miller
Browse files

net: packetengines: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles 



dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: default avatarYang Wei <yang.wei9@zte.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d1441d47

drivers/net/ethernet/packetengines/hamachi.c

+1 −1
Original line number Diff line number Diff line
@@ -1337,7 +1337,7 @@ static irqreturn_t hamachi_interrupt(int irq, void *dev_instance) 
							leXX_to_cpu(hmp->tx_ring[entry].addr),

							skb->len,

							PCI_DMA_TODEVICE);

						dev_kfree_skb_irq(skb);

						dev_consume_skb_irq(skb);

						hmp->tx_skbuff[entry] = NULL;

					}

					hmp->tx_ring[entry].status_n_length = 0;

drivers/net/ethernet/packetengines/yellowfin.c

+2 −2
Original line number Diff line number Diff line
@@ -925,7 +925,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance) 
			/* Free the original skb. */

			pci_unmap_single(yp->pci_dev, le32_to_cpu(yp->tx_ring[entry].addr),

				skb->len, PCI_DMA_TODEVICE);

			dev_kfree_skb_irq(skb);

			dev_consume_skb_irq(skb);

			yp->tx_skbuff[entry] = NULL;

		}

		if (yp->tx_full &&
@@ -983,7 +983,7 @@ static irqreturn_t yellowfin_interrupt(int irq, void *dev_instance) 
				pci_unmap_single(yp->pci_dev,

					yp->tx_ring[entry<<1].addr, skb->len,

					PCI_DMA_TODEVICE);

				dev_kfree_skb_irq(skb);

				dev_consume_skb_irq(skb);

				yp->tx_skbuff[entry] = 0;

				/* Mark status as empty. */

				yp->tx_status[entry].tx_errs = 0;