Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b7e5bdf authored by Nilesh Javali's avatar Nilesh Javali Committed by Greg Kroah-Hartman
Browse files

scsi: qla2xxx: Check valid rport returned by fc_bsg_to_rport() 



commit af73f23a27206ffb3c477cac75b5fcf03410556e upstream.

Klocwork reported warning of rport maybe NULL and will be dereferenced.
rport returned by call to fc_bsg_to_rport() could be NULL and dereferenced.

Check valid rport returned by fc_bsg_to_rport().

Cc: stable@vger.kernel.org
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-5-njavali@marvell.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f90a8b0

drivers/scsi/qla2xxx/qla_bsg.c

+4 −0
Original line number Diff line number Diff line
@@ -259,6 +259,10 @@ qla2x00_process_els(struct bsg_job *bsg_job) 


	if (bsg_request->msgcode == FC_BSG_RPT_ELS) {

		rport = fc_bsg_to_rport(bsg_job);

		if (!rport) {

			rval = -ENOMEM;

			goto done;

		}

		fcport = *(fc_port_t **) rport->dd_data;

		host = rport_to_shost(rport);

		vha = shost_priv(host);