Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b5c19c7 authored by Bruce Allan's avatar Bruce Allan Committed by Jeff Kirsher
Browse files

ice: fix static analysis warnings



cppcheck warns "Identical condition '<var>', second condition is always
false". Fix them.

Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 7eeac889
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -331,7 +331,7 @@ ice_aq_get_link_info(struct ice_port_info *pi, bool ena_lse,
	/* flag cleared so calling functions don't call AQ again */
	pi->phy.get_link_info = false;

	return status;
	return 0;
}

/**
+1 −1
Original line number Diff line number Diff line
@@ -2647,7 +2647,7 @@ static int ice_up_complete(struct ice_vsi *vsi)

	ice_service_task_schedule(pf);

	return err;
	return 0;
}

/**
+1 −1
Original line number Diff line number Diff line
@@ -1502,7 +1502,7 @@ ice_sched_update_vsi_child_nodes(struct ice_port_info *pi, u16 vsi_handle,

	vsi_ctx->sched.max_lanq[tc] = new_numqs;

	return status;
	return 0;
}

/**
+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ ice_add_vsi(struct ice_hw *hw, u16 vsi_handle, struct ice_vsi_ctx *vsi_ctx,
			tmp_vsi_ctx->vsi_num = vsi_ctx->vsi_num;
	}

	return status;
	return 0;
}

/**