Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b59625d authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

scsi: lpfc: Use correct scnprintf() limit 

[ Upstream commit 6dacc371b77f473770ec646e220303a84fe96c11 ]

The limit should be "PAGE_SIZE - len" instead of "PAGE_SIZE".  We're not
going to hit the limit so this fix will not affect runtime.

Link: https://lore.kernel.org/r/20210916132331.GE25094@kili


Fixes: 5b9e70b2 ("scsi: lpfc: raise sg count for nvme to use available sg resources")
Reviewed-by: default avatarJames Smart <jsmart2021@gmail.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 30d373dc

drivers/scsi/lpfc/lpfc_attr.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -5881,7 +5881,8 @@ lpfc_sg_seg_cnt_show(struct device *dev, struct device_attribute *attr, 
	len = scnprintf(buf, PAGE_SIZE, "SGL sz: %d  total SGEs: %d\n",

	len = scnprintf(buf, PAGE_SIZE, "SGL sz: %d  total SGEs: %d\n",

		       phba->cfg_sg_dma_buf_size, phba->cfg_total_seg_cnt);

		       phba->cfg_sg_dma_buf_size, phba->cfg_total_seg_cnt);





	len += scnprintf(buf + len, PAGE_SIZE, "Cfg: %d  SCSI: %d  NVME: %d\n",

	len += scnprintf(buf + len, PAGE_SIZE - len,

			"Cfg: %d  SCSI: %d  NVME: %d\n",

			phba->cfg_sg_seg_cnt, phba->cfg_scsi_seg_cnt,

			phba->cfg_sg_seg_cnt, phba->cfg_scsi_seg_cnt,

			phba->cfg_nvme_seg_cnt);

			phba->cfg_nvme_seg_cnt);

	return len;

	return len;