Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b57f132 authored by NeilBrown's avatar NeilBrown
Browse files

md: move assignment of ->utime so that it never gets skipped.



Currently the assignment to utime gets skipped for 'external'
metadata.  So move it to the top of the function so that it
always gets effected.
This is of largely cosmetic interest.  Nothing actually depends
on ->utime being right for external arrays.
"mdadm --monitor" does use it for 0.90 and 1.x arrays, but with
mdadm-3.0, this is not important for external metadata.

Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 8c6ac868
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1904,6 +1904,7 @@ static void md_update_sb(mddev_t * mddev, int force_change)
	int sync_req;
	int nospares = 0;

	mddev->utime = get_seconds();
	if (mddev->external)
		return;
repeat:
@@ -1933,7 +1934,6 @@ static void md_update_sb(mddev_t * mddev, int force_change)
		nospares = 0;

	sync_req = mddev->in_sync;
	mddev->utime = get_seconds();

	/* If this is just a dirty<->clean transition, and the array is clean
	 * and 'events' is odd, we can roll back to the previous clean state */