Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b37ec85 authored by Al Viro's avatar Al Viro Committed by Greg Kroah-Hartman
Browse files

memcg_write_event_control(): fix a user-triggerable oops 



commit 046667c4d3196938e992fba0dfcde570aa85cd0e upstream.

we are *not* guaranteed that anything past the terminating NUL
is mapped (let alone initialized with anything sane).

Fixes: 0dea1168 ("cgroup: implement eventfd-based generic API for notifications")
Cc: stable@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a71a6db1

mm/memcontrol.c

+5 −2
Original line number Diff line number Diff line
@@ -4732,9 +4732,12 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, 
	buf = endp + 1;



	cfd = simple_strtoul(buf, &endp, 10);

	if ((*endp != ' ') && (*endp != '\0'))

		return -EINVAL;

	if (*endp == '\0')

		buf = endp;

	else if (*endp == ' ')

		buf = endp + 1;

	else

		return -EINVAL;



	event = kzalloc(sizeof(*event), GFP_KERNEL);

	if (!event)