Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ae5ccc7 authored by Mark Bloch's avatar Mark Bloch Committed by Doug Ledford
Browse files

IB/core: Remove unnecessary check in ibnl_rcv_msg 



RDMA_NL_GET_OP is defined like this: (type & ((1 << 10) - 1))
which means op (defined as an int) can never be a negative number.

Fixes: b2cbae2c ('RDMA: Add netlink infrastructure')
Signed-off-by: default avatarMark Bloch <markb@mellanox.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 5ed935e8

drivers/infiniband/core/netlink.c

+2 −3
Original line number Diff line number Diff line
@@ -151,12 +151,11 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh) 
	struct ibnl_client *client;

	int type = nlh->nlmsg_type;

	int index = RDMA_NL_GET_CLIENT(type);

	int op = RDMA_NL_GET_OP(type);

	unsigned int op = RDMA_NL_GET_OP(type);



	list_for_each_entry(client, &client_list, list) {

		if (client->index == index) {

			if (op < 0 || op >= client->nops ||

			    !client->cb_table[op].dump)

			if (op >= client->nops || !client->cb_table[op].dump)

				return -EINVAL;



			/*