Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1adc90c7 authored by Aditya Pakki's avatar Aditya Pakki Committed by Linus Walleij
Browse files

pinctrl: axp209: Fix NULL pointer dereference after allocation 



axp20x_build_funcs_groups allocates groups via devm_kcalloc and tries to
dereference without checking for NULL. This patch avoids such a
scenario.

Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 182e80ee

drivers/pinctrl/pinctrl-axp209.c

+2 −0
Original line number Diff line number Diff line
@@ -366,6 +366,8 @@ static int axp20x_build_funcs_groups(struct platform_device *pdev) 
		pctl->funcs[i].groups = devm_kcalloc(&pdev->dev,

						     npins, sizeof(char *),

						     GFP_KERNEL);

		if (!pctl->funcs[i].groups)

			return -ENOMEM;

		for (pin = 0; pin < npins; pin++)

			pctl->funcs[i].groups[pin] = pctl->desc->pins[pin].name;

	}