Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a92f989 authored by Bibby Hsieh's avatar Bibby Hsieh Committed by Matthias Brugger
Browse files

soc: mediatek: cmdq: reorder the parameter 



The order of gce instructions is [subsys offset value]
so reorder the parameter of cmdq_pkt_write_mask
and cmdq_pkt_write function.

Signed-off-by: default avatarBibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Signed-off-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
parent 5f9e832c

drivers/soc/mediatek/mtk-cmdq-helper.c

+3 −3
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static int cmdq_pkt_append_command(struct cmdq_pkt *pkt, enum cmdq_code code, 
	return 0;

}



int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset)

int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value)

{

	u32 arg_a = (offset & CMDQ_ARG_A_WRITE_MASK) |

		    (subsys << CMDQ_SUBSYS_SHIFT);
@@ -145,8 +145,8 @@ int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset) 
}

EXPORT_SYMBOL(cmdq_pkt_write);



int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 value,

			u32 subsys, u32 offset, u32 mask)

int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,

			u32 offset, u32 value, u32 mask)

{

	u32 offset_mask = offset;

	int err = 0;

include/linux/soc/mediatek/mtk-cmdq.h

+5 −5
Original line number Diff line number Diff line
@@ -63,26 +63,26 @@ void cmdq_pkt_destroy(struct cmdq_pkt *pkt); 
/**

 * cmdq_pkt_write() - append write command to the CMDQ packet

 * @pkt:	the CMDQ packet

 * @value:	the specified target register value

 * @subsys:	the CMDQ sub system code

 * @offset:	register offset from CMDQ sub system

 * @value:	the specified target register value

 *

 * Return: 0 for success; else the error code is returned

 */

int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 value, u32 subsys, u32 offset);

int cmdq_pkt_write(struct cmdq_pkt *pkt, u32 subsys, u32 offset, u32 value);



/**

 * cmdq_pkt_write_mask() - append write command with mask to the CMDQ packet

 * @pkt:	the CMDQ packet

 * @value:	the specified target register value

 * @subsys:	the CMDQ sub system code

 * @offset:	register offset from CMDQ sub system

 * @value:	the specified target register value

 * @mask:	the specified target register mask

 *

 * Return: 0 for success; else the error code is returned

 */

int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 value,

			u32 subsys, u32 offset, u32 mask);

int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u32 subsys,

			u32 offset, u32 value, u32 mask);



/**

 * cmdq_pkt_wfe() - append wait for event command to the CMDQ packet