Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1a8b18af authored by Fabien Dessenne's avatar Fabien Dessenne Committed by Mauro Carvalho Chehab
Browse files

[media] bdisp: remove needless check 



As reported by smatch:
	drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.width' is never less than zero.
	drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.height' is never less than zero.
Indeed, width and height are unsigned.

Signed-off-by: default avatarFabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 87b09bd0

drivers/media/platform/sti/bdisp/bdisp-v4l2.c

+1 −2
Original line number Diff line number Diff line
@@ -944,8 +944,7 @@ static int bdisp_s_selection(struct file *file, void *fh, 
	out.width = ALIGN(in->width, frame->fmt->w_align);

	out.height = ALIGN(in->height, frame->fmt->w_align);



	if ((out.width < 0) || (out.height < 0) ||

	    ((out.left + out.width) > frame->width) ||

	if (((out.left + out.width) > frame->width) ||

	    ((out.top + out.height) > frame->height)) {

		dev_err(ctx->bdisp_dev->dev,

			"Invalid crop: %dx%d@(%d,%d) vs frame: %dx%d\n",