Commit 1a2d21e2 authored Apr 10, 2021 by Wang Li Committed by Greg Kroah-Hartman Jul 19, 2021

drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()



[ Upstream commit 69777e6ca396f0a7e1baff40fcad4a9d3d445b7a ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Li <wangli74@huawei.com>
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 45cc7a65

drivers/gpu/drm/mediatek/mtk_drm_crtc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -240,7 +240,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
		drm_connector_list_iter_end(&conn_iter);
		}

		ret = pm_runtime_get_sync(crtc->dev->dev);
		ret = pm_runtime_resume_and_get(crtc->dev->dev);
		if (ret < 0) {
		DRM_ERROR("Failed to enable power domain: %d\n", ret);
		return ret;