Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19db2307 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Martin K. Petersen
Browse files

lpfc: Remove redundant code block in lpfc_scsi_cmd_iocb_cmpl 



This removes a redundant code block that will either be executed if the
ENABLE_FCP_RING_POLLING flag is set in phba->cfg_poll or not. The code
is just duplicated in both cases, hence we unify it again.

This probably is a left over from some sort of refactoring.

Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Reviewed-by: default avatarTomas Henzl <thenzl@redhat.com>
Reviewed-by: default avatarSebastian Herbszt <herbszt@gmx.de>
Acked-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d867b655

drivers/scsi/lpfc/lpfc_scsi.c

+0 −17
Original line number Diff line number Diff line
@@ -4139,23 +4139,6 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn, 
	/* The sdev is not guaranteed to be valid post scsi_done upcall. */

	cmd->scsi_done(cmd);



	if (phba->cfg_poll & ENABLE_FCP_RING_POLLING) {

		spin_lock_irqsave(&phba->hbalock, flags);

		lpfc_cmd->pCmd = NULL;

		spin_unlock_irqrestore(&phba->hbalock, flags);



		/*

		 * If there is a thread waiting for command completion

		 * wake up the thread.

		 */

		spin_lock_irqsave(shost->host_lock, flags);

		if (lpfc_cmd->waitq)

			wake_up(lpfc_cmd->waitq);

		spin_unlock_irqrestore(shost->host_lock, flags);

		lpfc_release_scsi_buf(phba, lpfc_cmd);

		return;

	}



	spin_lock_irqsave(&phba->hbalock, flags);

	lpfc_cmd->pCmd = NULL;

	spin_unlock_irqrestore(&phba->hbalock, flags);