Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19d55046 authored by Trond Myklebust's avatar Trond Myklebust Committed by Anna Schumaker
Browse files

SUNRPC: Fix a credential refcount leak 



All callers of __rpc_clone_client() pass in a value for args->cred,
meaning that the credential gets assigned and referenced in
the call to rpc_new_client().

Reported-by: default avatarIdo Schimmel <idosch@idosch.org>
Fixes: 79caa5fa ("SUNRPC: Cache cred of process creating the rpc_client")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Tested-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 502980e8

net/sunrpc/clnt.c

+0 −1
Original line number Diff line number Diff line
@@ -634,7 +634,6 @@ static struct rpc_clnt *__rpc_clone_client(struct rpc_create_args *args, 
	new->cl_discrtry = clnt->cl_discrtry;

	new->cl_chatty = clnt->cl_chatty;

	new->cl_principal = clnt->cl_principal;

	new->cl_cred = get_cred(clnt->cl_cred);

	return new;



out_err: