Commit 19d46ee1 authored Apr 16, 2016 by Giedrius Statkevičius Committed by Darren Hart Apr 25, 2016

asus-laptop: correct error handling in sysfs_acpi_set



Properly return rv back to the caller in the case of an error in
parse_arg. In the process remove a unused variable 'out'.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>

parent 2ce6d993

drivers/platform/x86/asus-laptop.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -948,11 +948,10 @@ static ssize_t sysfs_acpi_set(struct asus_laptop *asus,
		const char *method)
		{
		int rv, value;
		int out = 0;

		rv = parse_arg(buf, count, &value);
		if (rv > 0)
		out = value ? 1 : 0;
		if (rv <= 0)
		return rv;

		if (write_acpi_int(asus->handle, method, value))
		return -ENODEV;