Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19c2b6d8 authored by Saurav Kashyap's avatar Saurav Kashyap Committed by Martin K. Petersen
Browse files

scsi: qedf: Check the return value of start_xmit 



Log the reason for start xmit failure.

Signed-off-by: default avatarSaurav Kashyap <skashyap@marvell.com>
Signed-off-by: default avatarChad Dupuis <cdupuis@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 249b148f

drivers/scsi/qedf/qedf_fip.c

+15 −2
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ void qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf) 
#define MY_FIP_ALL_FCF_MACS        ((__u8[6]) { 1, 0x10, 0x18, 1, 0, 2 })

	static u8 my_fcoe_all_fcfs[ETH_ALEN] = MY_FIP_ALL_FCF_MACS;

	unsigned long flags = 0;

	int rc = -1;



	skb = dev_alloc_skb(sizeof(struct fip_vlan));

	if (!skb)
@@ -66,7 +67,13 @@ void qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf) 
	}



	set_bit(QED_LL2_XMIT_FLAGS_FIP_DISCOVERY, &flags);

	qed_ops->ll2->start_xmit(qedf->cdev, skb, flags);

	rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, flags);

	if (rc) {

		QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc);

		kfree_skb(skb);

		return;

	}



}



static void qedf_fcoe_process_vlan_resp(struct qedf_ctx *qedf,
@@ -118,6 +125,7 @@ void qedf_fip_send(struct fcoe_ctlr *fip, struct sk_buff *skb) 
	struct fip_header *fiph;

	u16 op, vlan_tci = 0;

	u8 sub;

	int rc = -1;



	if (!test_bit(QEDF_LL2_STARTED, &qedf->flags)) {

		QEDF_WARN(&(qedf->dbg_ctx), "LL2 not started\n");
@@ -146,7 +154,12 @@ void qedf_fip_send(struct fcoe_ctlr *fip, struct sk_buff *skb) 
		print_hex_dump(KERN_WARNING, "fip ", DUMP_PREFIX_OFFSET, 16, 1,

		    skb->data, skb->len, false);



	qed_ops->ll2->start_xmit(qedf->cdev, skb, 0);

	rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, 0);

	if (rc) {

		QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc);

		kfree_skb(skb);

		return;

	}

}



static u8 fcoe_all_enode[ETH_ALEN] = FIP_ALL_ENODE_MACS;

drivers/scsi/qedf/qedf_main.c

+6 −1
Original line number Diff line number Diff line
@@ -1141,7 +1141,12 @@ static int qedf_xmit(struct fc_lport *lport, struct fc_frame *fp) 
	if (qedf_dump_frames)

		print_hex_dump(KERN_WARNING, "fcoe: ", DUMP_PREFIX_OFFSET, 16,

		    1, skb->data, skb->len, false);

	qed_ops->ll2->start_xmit(qedf->cdev, skb, 0);

	rc = qed_ops->ll2->start_xmit(qedf->cdev, skb, 0);

	if (rc) {

		QEDF_ERR(&qedf->dbg_ctx, "start_xmit failed rc = %d.\n", rc);

		kfree_skb(skb);

		return rc;

	}



	return 0;

}