Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19a4fbff authored by Ricardo Ribalda Delgado's avatar Ricardo Ribalda Delgado Committed by Linus Walleij
Browse files

gpiolib: Free the last requested descriptor 



The current code only frees N-1 gpios if an error occurs during
gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input.
Leading to gpios that cannot be used by userspace nor other drivers.

Cc: Timur Tabi <timur@codeaurora.org>
Cc: stable@vger.kernel.org
Fixes: ab3dbcf7 ("gpioib: do not free unrequested descriptors)
Reported-by: default avatarJan Lorenzen <jl@newtec.dk>
Reported-by: default avatarJim Paris <jim@jtan.com>
Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 7876320f

drivers/gpio/gpiolib.c

+1 −1
Original line number Diff line number Diff line
@@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip) 
		if (ret)

			goto out_free_descs;

		lh->descs[i] = desc;

		count = i;

		count = i + 1;



		if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW)

			set_bit(FLAG_ACTIVE_LOW, &desc->flags);