Commit 197df18f authored Jul 09, 2019 by Nishka Dasgupta Committed by Lee Jones Jul 25, 2019

mfd: max77620: Add of_node_put() before return



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 5f9e832c

drivers/mfd/max77620.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -416,9 +416,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip)

		for_each_child_of_node(fps_np, fps_child) {
		ret = max77620_config_fps(chip, fps_child);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(fps_child);
		return ret;
		}
		}

		config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0;
		ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2,