Commit 19418b02 authored Oct 10, 2018 by Alexander Duyck Committed by Dan Williams Oct 12, 2018

nvdimm: Remove empty if statement



This patch removes an empty statement from an if expression and promotes
the else statement to the if expression with the expression logic reversed.

I feel this is more readable as the empty statement can lead to issues if
any additional logic was ever added.

Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 1cfeb66e

drivers/nvdimm/label.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -261,9 +261,8 @@ int nd_label_validate(struct nvdimm_drvdata *ndd)
		void nd_label_copy(struct nvdimm_drvdata ndd, struct nd_namespace_index dst,
		struct nd_namespace_index *src)
		{
		if (dst && src)
		/* pass */;
		else
		/* just exit if either destination or source is NULL */
		if (!dst \|\| !src)
		return;

		memcpy(dst, src, sizeof_namespace_index(ndd));