Commit 18ec3c12 authored Feb 22, 2019 by Dan Carpenter Committed by Ben Skeggs Mar 22, 2019

drm/nouveau/dmem: Fix a NULL vs IS_ERR() check



The hmm_devmem_add() function doesn't return NULL, it returns error
pointers.

Fixes: 5be73b69 ("drm/nouveau/dmem: device memory helpers for SVM")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 2219c9ee

drivers/gpu/drm/nouveau/nouveau_dmem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -621,7 +621,7 @@ nouveau_dmem_init(struct nouveau_drm *drm)
		*/
		drm->dmem->devmem = hmm_devmem_add(&nouveau_dmem_devmem_ops,
		device, size);
		if (drm->dmem->devmem == NULL) {
		if (IS_ERR(drm->dmem->devmem)) {
		kfree(drm->dmem);
		drm->dmem = NULL;
		return;