Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18dd8e1a authored by Steve French's avatar Steve French
Browse files

Do not send SMB3 SET_INFO request if nothing is changing 



[CIFS] We had cases where we sent a SMB2/SMB3 setinfo request with all
timestamp (and DOS attribute) fields marked as 0 (ie do not change)
e.g. on chmod or chown.

Signed-off-by: default avatarSteve French <steve.french@primarydata.com>
CC: Stable <stable@vger.kernel.org>
parent 141891f4

fs/cifs/smb2inode.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -266,9 +266,15 @@ smb2_set_file_info(struct inode *inode, const char *full_path, 
	struct tcon_link *tlink;

	struct tcon_link *tlink;

	int rc;

	int rc;





	if ((buf->CreationTime == 0) && (buf->LastAccessTime == 0) &&

	    (buf->LastWriteTime == 0) && (buf->ChangeTime) &&

	    (buf->Attributes == 0))

		return 0; /* would be a no op, no sense sending this */



	tlink = cifs_sb_tlink(cifs_sb);

	tlink = cifs_sb_tlink(cifs_sb);

	if (IS_ERR(tlink))

	if (IS_ERR(tlink))

		return PTR_ERR(tlink);

		return PTR_ERR(tlink);



	rc = smb2_open_op_close(xid, tlink_tcon(tlink), cifs_sb, full_path,

	rc = smb2_open_op_close(xid, tlink_tcon(tlink), cifs_sb, full_path,

				FILE_WRITE_ATTRIBUTES, FILE_OPEN, 0, buf,

				FILE_WRITE_ATTRIBUTES, FILE_OPEN, 0, buf,

				SMB2_OP_SET_INFO);

				SMB2_OP_SET_INFO);