Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1879fe9e authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

wifi: libertas: if_usb: don't call kfree_skb() under spin_lock_irqsave() 



[ Upstream commit 3968e81ba644f10a7d45bae2539560db9edac501 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: a3128fee ("libertas: use irqsave() in USB's complete callback")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150008.111743-3-yangyingliang@huawei.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 0b7b7347

drivers/net/wireless/marvell/libertas/if_usb.c

+1 −1
Original line number Diff line number Diff line
@@ -637,7 +637,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff, 
	priv->resp_len[i] = (recvlength - MESSAGE_HEADER_LEN);

	memcpy(priv->resp_buf[i], recvbuff + MESSAGE_HEADER_LEN,

		priv->resp_len[i]);

	kfree_skb(skb);

	dev_kfree_skb_irq(skb);

	lbs_notify_command_response(priv, i);



	spin_unlock_irqrestore(&priv->driver_lock, flags);