Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1842dde0 authored by Miroslav Benes's avatar Miroslav Benes Committed by Greg Kroah-Hartman
Browse files

module: set MODULE_STATE_GOING state when a module fails to load 



[ Upstream commit 5e8ed280dab9eeabc1ba0b2db5dbe9fe6debb6b5 ]

If a module fails to load due to an error in prepare_coming_module(),
the following error handling in load_module() runs with
MODULE_STATE_COMING in module's state. Fix it by correctly setting
MODULE_STATE_GOING under "bug_cleanup" label.

Signed-off-by: default avatarMiroslav Benes <mbenes@suse.cz>
Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 569da7c3

kernel/module.c

+1 −0
Original line number Diff line number Diff line
@@ -3953,6 +3953,7 @@ static int load_module(struct load_info *info, const char __user *uargs, 
				     MODULE_STATE_GOING, mod);

	klp_module_going(mod);

 bug_cleanup:

	mod->state = MODULE_STATE_GOING;

	/* module_bug_cleanup needs module_mutex protection */

	mutex_lock(&module_mutex);

	module_bug_cleanup(mod);