Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1821dce9 authored by Yunsheng Lin's avatar Yunsheng Lin Committed by David S. Miller
Browse files

net: hns3: add error handling in hclge_ieee_setets 



Currently hclge_ieee_setets returns error directly when there is
error, which may cause netdev not up problem.

This patch adds some error handling when setting ETS configuration
fails.

Fixes: cacde272 ("net: hns3: Add hclge_dcb module for the support of DCB feature")
Signed-off-by: default avatarYunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac864c23

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c

+13 −2
Original line number Diff line number Diff line
@@ -232,12 +232,13 @@ static int hclge_ieee_setets(struct hnae3_handle *h, struct ieee_ets *ets) 


	ret = hclge_ieee_ets_to_tm_info(hdev, ets);

	if (ret)

		return ret;

		goto err_out;



	if (map_changed) {

		ret = hclge_client_setup_tc(hdev);

		if (ret)

			return ret;

			goto err_out;



		ret = hclge_notify_client(hdev, HNAE3_INIT_CLIENT);

		if (ret)

			return ret;
@@ -248,6 +249,16 @@ static int hclge_ieee_setets(struct hnae3_handle *h, struct ieee_ets *ets) 
	}



	return hclge_tm_dwrr_cfg(hdev);



err_out:

	if (!map_changed)

		return ret;



	if (hclge_notify_client(hdev, HNAE3_INIT_CLIENT))

		return ret;



	hclge_notify_client(hdev, HNAE3_UP_CLIENT);

	return ret;

}



static int hclge_ieee_getpfc(struct hnae3_handle *h, struct ieee_pfc *pfc)