Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18203fe1 authored by David Ahern's avatar David Ahern Committed by Greg Kroah-Hartman
Browse files

selftests: Fix IPv6 address bind tests 



[ Upstream commit 28a2686c185e84b6aa6a4d9c9a972360eb7ca266 ]

IPv6 allows binding a socket to a device then binding to an address
not on the device (__inet6_bind -> ipv6_chk_addr with strict flag
not set). Update the bind tests to reflect legacy behavior.

Fixes: 34d0302a ("selftests: Add ipv6 address bind tests to fcnal-test")
Reported-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b46f0afa

tools/testing/selftests/net/fcnal-test.sh

+13 −5
Original line number Diff line number Diff line
@@ -2891,11 +2891,14 @@ ipv6_addr_bind_novrf() 
	run_cmd nettest -6 -s -l ${a} -d ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 0 "TCP socket bind to local address after device bind"



	# Sadly, the kernel allows binding a socket to a device and then

	# binding to an address not on the device. So this test passes

	# when it really should not

	a=${NSA_LO_IP6}

	log_start

	show_hint "Should fail with 'Cannot assign requested address'"

	run_cmd nettest -6 -s -l ${a} -d ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 1 "TCP socket bind to out of scope local address"

	show_hint "Tecnically should fail since address is not on device but kernel allows"

	run_cmd nettest -6 -s -l ${a} -I ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 0 "TCP socket bind to out of scope local address"

}



ipv6_addr_bind_vrf()
@@ -2936,10 +2939,15 @@ ipv6_addr_bind_vrf() 
	run_cmd nettest -6 -s -l ${a} -d ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 0 "TCP socket bind to local address with device bind"



	# Sadly, the kernel allows binding a socket to a device and then

	# binding to an address not on the device. The only restriction

	# is that the address is valid in the L3 domain. So this test

	# passes when it really should not

	a=${VRF_IP6}

	log_start

	run_cmd nettest -6 -s -l ${a} -d ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 1 "TCP socket bind to VRF address with device bind"

	show_hint "Tecnically should fail since address is not on device but kernel allows"

	run_cmd nettest -6 -s -l ${a} -I ${NSA_DEV} -t1 -b

	log_test_addr ${a} $? 0 "TCP socket bind to VRF address with device bind"



	a=${NSA_LO_IP6}

	log_start