Commit 180a8c3d authored Mar 27, 2019 by Colin Ian King Committed by David S. Miller Mar 27, 2019

net: phy: mdio-bcm-unimac: remove redundant !timeout check



The check for zero timeout is always true at the end of the proceeding
while loop; the only other exit path in the loop is if the unimac MDIO
is not busy.  Remove the redundant zero timeout check and always
return -ETIMEDOUT on this timeout return path.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4f661542

drivers/net/phy/mdio-bcm-unimac.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -92,10 +92,7 @@ static int unimac_mdio_poll(void *wait_func_data)
		usleep_range(1000, 2000);
		} while (--timeout);

		if (!timeout)
		return -ETIMEDOUT;

		return 0;
		}

		static int unimac_mdio_read(struct mii_bus *bus, int phy_id, int reg)