Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17bebdcd authored by Julia Lawall's avatar Julia Lawall Committed by Herbert Xu
Browse files

crypto: bfin_crc - reposition free_irq to avoid access to invalid data 

The data referenced by an interrupt handler should not be freed before the
interrupt is ended.  The handler is bfin_crypto_crc_handler.  It may refer
to crc->regs, which is released by the iounmap.

Furthermore, the second argument to all calls to free_irq is incorrect.  It
should be the same as the last argument of request_irq, which is crc,
rather than crc->dev.

The semantic match that finds the first problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@FN exists@
expression list es;
expression a,b;
identifier f;
@@

if (...) {
  ... when any
  free_irq(a,b);
  ... when any
  f(es);
  ... when any
  return ...;
}

@@
expression list fn.es;
expression fn.a,fn.b;
identifier fn.f;
@@

*f(es);
... when any
*free_irq(a,b);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent d20fb18b

drivers/crypto/bfin_crc.c

+3 −3
Original line number Diff line number Diff line
@@ -694,7 +694,7 @@ static int __devinit bfin_crypto_crc_probe(struct platform_device *pdev) 
		dma_free_coherent(&pdev->dev, PAGE_SIZE, crc->sg_cpu, crc->sg_dma);

	free_dma(crc->dma_ch);

out_error_irq:

	free_irq(crc->irq, crc->dev);

	free_irq(crc->irq, crc);

out_error_unmap:

	iounmap((void *)crc->regs);

out_error_free_mem:
@@ -720,10 +720,10 @@ static int __devexit bfin_crypto_crc_remove(struct platform_device *pdev) 


	crypto_unregister_ahash(&algs);

	tasklet_kill(&crc->done_task);

	iounmap((void *)crc->regs);

	free_dma(crc->dma_ch);

	if (crc->irq > 0)

		free_irq(crc->irq, crc->dev);

		free_irq(crc->irq, crc);

	iounmap((void *)crc->regs);

	kfree(crc);



	return 0;