Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 17b963e3 authored by David Howells's avatar David Howells
Browse files

rxrpc: Need to flag call as being released on connect failure 



If rxrpc_new_client_call() fails to make a connection, the call record that
it allocated needs to be marked as RXRPC_CALL_RELEASED before it is passed
to rxrpc_put_call() to indicate that it no longer has any attachment to the
AF_RXRPC socket.

Without this, an assertion failure may occur at:

	net/rxrpc/call_object:635

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 55cae7a4

net/rxrpc/call_object.c

+2 −0
Original line number Diff line number Diff line
@@ -275,6 +275,7 @@ struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx, 
	list_del_init(&call->link);

	write_unlock_bh(&rxrpc_call_lock);



	set_bit(RXRPC_CALL_RELEASED, &call->flags);

	call->state = RXRPC_CALL_DEAD;

	rxrpc_put_call(call);

	_leave(" = %d", ret);
@@ -287,6 +288,7 @@ struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx, 
	 */

found_user_ID_now_present:

	write_unlock(&rx->call_lock);

	set_bit(RXRPC_CALL_RELEASED, &call->flags);

	call->state = RXRPC_CALL_DEAD;

	rxrpc_put_call(call);

	_leave(" = -EEXIST [%p]", call);