Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1796ae6a authored by Wenchao Chen's avatar Wenchao Chen Committed by Greg Kroah-Hartman
Browse files

mmc: sdhci-sprd: Fix vqmmc not shutting down after the card was pulled 



[ Upstream commit 477865af60b2117ceaa1d558e03559108c15c78c ]

With cat regulator_summary, we found that vqmmc was not shutting
down after the card was pulled.

cat /sys/kernel/debug/regulator/regulator_summary
1.before fix
1)Insert SD card
 vddsdio		1    1  0 unknown  3500mV 0mA  1200mV  3750mV
    71100000.mmc-vqmmc  1                         0mA  3500mV  3600mV

2)Pull out the SD card
 vddsdio                1    1  0 unknown  3500mV 0mA  1200mV  3750mV
    71100000.mmc-vqmmc  1                         0mA  3500mV  3600mV

2.after fix
1)Insert SD cardt
 vddsdio                1    1  0 unknown  3500mV 0mA  1200mV  3750mV
    71100000.mmc-vqmmc  1                         0mA  3500mV  3600mV

2)Pull out the SD card
 vddsdio		0    1  0 unknown  3500mV 0mA  1200mV  3750mV
    71100000.mmc-vqmmc  0                         0mA  3500mV  3600mV

Fixes: fb8bd90f ("mmc: sdhci-sprd: Add Spreadtrum's initial host controller")
Signed-off-by: default avatarWenchao Chen <wenchao.chen@unisoc.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20231115083406.7368-1-wenchao.chen@unisoc.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a1f29e99

drivers/mmc/host/sdhci-sprd.c

+25 −0
Original line number Diff line number Diff line
@@ -381,12 +381,33 @@ static unsigned int sdhci_sprd_get_ro(struct sdhci_host *host) 
	return 0;

}



static void sdhci_sprd_set_power(struct sdhci_host *host, unsigned char mode,

				 unsigned short vdd)

{

	struct mmc_host *mmc = host->mmc;



	switch (mode) {

	case MMC_POWER_OFF:

		mmc_regulator_set_ocr(host->mmc, mmc->supply.vmmc, 0);



		mmc_regulator_disable_vqmmc(mmc);

		break;

	case MMC_POWER_ON:

		mmc_regulator_enable_vqmmc(mmc);

		break;

	case MMC_POWER_UP:

		mmc_regulator_set_ocr(host->mmc, mmc->supply.vmmc, vdd);

		break;

	}

}



static struct sdhci_ops sdhci_sprd_ops = {

	.read_l = sdhci_sprd_readl,

	.write_l = sdhci_sprd_writel,

	.write_w = sdhci_sprd_writew,

	.write_b = sdhci_sprd_writeb,

	.set_clock = sdhci_sprd_set_clock,

	.set_power = sdhci_sprd_set_power,

	.get_max_clock = sdhci_sprd_get_max_clock,

	.get_min_clock = sdhci_sprd_get_min_clock,

	.set_bus_width = sdhci_set_bus_width,
@@ -630,6 +651,10 @@ static int sdhci_sprd_probe(struct platform_device *pdev) 
	host->caps1 &= ~(SDHCI_SUPPORT_SDR50 | SDHCI_SUPPORT_SDR104 |

			 SDHCI_SUPPORT_DDR50);



	ret = mmc_regulator_get_supply(host->mmc);

	if (ret)

		goto pm_runtime_disable;



	ret = sdhci_setup_host(host);

	if (ret)

		goto pm_runtime_disable;