Commit 176a3c48 authored Jun 20, 2020 by Bernard Zhao Committed by Sasha Levin Jun 30, 2020

drm/amd: fix potential memleak in err branch



commit b5b78a6c8d8cb9c307bc6b16a754603424459d6e upstream.

The function kobject_init_and_add alloc memory like:
kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
->kmalloc_slab, in err branch this memory not free. If use
kmemleak, this path maybe catched.
These changes are to add kobject_put in kobject_init_and_add
failed branch, fix potential memleak.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 0b3cc973

drivers/gpu/drm/amd/amdkfd/kfd_process.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -312,6 +312,7 @@ struct kfd_process kfd_create_process(struct file filep)
		(int)process->lead_thread->pid);
		if (ret) {
		pr_warn("Creating procfs pid directory failed");
		kobject_put(process->kobj);
		goto out;
		}