Commit 175f7c1f authored Apr 12, 2019 by Tetsuo Handa Committed by David S. Miller Apr 12, 2019

sctp: Check address length before reading address family



KMSAN will complain if valid address length passed to connect() is shorter
than sizeof("struct sockaddr"->sa_family) bytes.

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 238ffdc4

net/sctp/socket.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4847,7 +4847,8 @@ static int sctp_connect(struct sock sk, struct sockaddr addr,
		}

		/* Validate addr_len before calling common connect/connectx routine. */
		af = sctp_get_af_specific(addr->sa_family);
		af = addr_len < offsetofend(struct sockaddr, sa_family) ? NULL :
		sctp_get_af_specific(addr->sa_family);
		if (!af \|\| addr_len < af->sockaddr_len) {
		err = -EINVAL;
		} else {