Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 170e8e61 authored by Toke Høiland-Jørgensen's avatar Toke Høiland-Jørgensen Committed by Kalle Valo
Browse files

ath10k: re-enable TXQs for all devices 

Commit 4ca18078 ("ath10k: disable wake_tx_queue for older devices")
disables the use of the mac80211 TXQs for some devices because of a theoretical
throughput regression. The original regression report[1] was related to
fq_codel qdisc drop performance, which was fixed in commit 9d18562a
("fq_codel: add batch ability to fq_codel_drop()"). Since then, we have not
seen the TXQ-related regression, so it should be safe to re-enable TXQs.

[1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html



Signed-off-by: default avatarToke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 626ab670

drivers/net/wireless/ath/ath10k/mac.c

+0 −9
Original line number Original line Diff line number Diff line
@@ -8329,15 +8329,6 @@ int ath10k_mac_register(struct ath10k *ar) 
			ath10k_warn(ar, "failed to initialise DFS pattern detector\n");

			ath10k_warn(ar, "failed to initialise DFS pattern detector\n");

	}

	}





	/* Current wake_tx_queue implementation imposes a significant

	 * performance penalty in some setups. The tx scheduling code needs

	 * more work anyway so disable the wake_tx_queue unless firmware

	 * supports the pull-push mechanism.

	 */

	if (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL,

		      ar->running_fw->fw_file.fw_features))

		ar->ops->wake_tx_queue = NULL;



	ret = ath10k_mac_init_rd(ar);

	ret = ath10k_mac_init_rd(ar);

	if (ret) {

	if (ret) {

		ath10k_err(ar, "failed to derive regdom: %d\n", ret);

		ath10k_err(ar, "failed to derive regdom: %d\n", ret);