Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16badf75 authored by Sudheer Mogilappagari's avatar Sudheer Mogilappagari Committed by Jeff Kirsher
Browse files

i40e: Fix unqualified module message while bringing link up 



In current driver, when ifconfig ethx up is done, the link state
doesn't transition to UP inside i40e_open(). It changes after AQ
command response is handled in i40e_handle_link_event().

When pf->hw.phy.link_info.link_info is DOWN inside i40e_open(),
The state is transient and invalid. So log message gets printed
based on incorrect info (i.e link_info and an_info).

This commit removes check for unqualified module inside
i40e_up_complete(). The existing check in i40e_handle_link_event()
logs the error message based on correct link state information.

Signed-off-by: default avatarSudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 2b634bb0

drivers/net/ethernet/intel/i40e/i40e_main.c

+0 −9
Original line number Diff line number Diff line
@@ -5470,15 +5470,6 @@ static int i40e_up_complete(struct i40e_vsi *vsi) 
		i40e_print_link_message(vsi, true);

		netif_tx_start_all_queues(vsi->netdev);

		netif_carrier_on(vsi->netdev);

	} else if (vsi->netdev) {

		i40e_print_link_message(vsi, false);

		/* need to check for qualified module here*/

		if ((pf->hw.phy.link_info.link_info &

			I40E_AQ_MEDIA_AVAILABLE) &&

		    (!(pf->hw.phy.link_info.an_info &

			I40E_AQ_QUALIFIED_MODULE)))

			netdev_err(vsi->netdev,

				   "the driver failed to link because an unqualified module was detected.");

	}



	/* replay FDIR SB filters */