Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 16a1258a authored by Mika Westerberg's avatar Mika Westerberg Committed by Greg Kroah-Hartman
Browse files

thunderbolt: Use const buffer pointer in write operations 



These functions should not (and do not) modify the argument in any way
so make it const.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: default avatarYehezkel Bernat <yehezkel.bernat@intel.com>
Reviewed-by: default avatarMichael Jamet <michael.jamet@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarAndreas Noever <andreas.noever@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 73726380

drivers/thunderbolt/ctl.c

+4 −4
Original line number Diff line number Diff line
@@ -273,7 +273,7 @@ static void tb_cfg_print_error(struct tb_ctl *ctl, 
	}

}



static void cpu_to_be32_array(__be32 *dst, u32 *src, size_t len)

static void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)

{

	int i;

	for (i = 0; i < len; i++)
@@ -333,7 +333,7 @@ static void tb_ctl_tx_callback(struct tb_ring *ring, struct ring_frame *frame, 
 *

 * Return: Returns 0 on success or an error code on failure.

 */

static int tb_ctl_tx(struct tb_ctl *ctl, void *data, size_t len,

static int tb_ctl_tx(struct tb_ctl *ctl, const void *data, size_t len,

		     enum tb_cfg_pkg_type type)

{

	int res;
@@ -650,7 +650,7 @@ struct tb_cfg_result tb_cfg_read_raw(struct tb_ctl *ctl, void *buffer, 
 *

 * Offset and length are in dwords.

 */

struct tb_cfg_result tb_cfg_write_raw(struct tb_ctl *ctl, void *buffer,

struct tb_cfg_result tb_cfg_write_raw(struct tb_ctl *ctl, const void *buffer,

		u64 route, u32 port, enum tb_cfg_space space,

		u32 offset, u32 length, int timeout_msec)

{
@@ -695,7 +695,7 @@ int tb_cfg_read(struct tb_ctl *ctl, void *buffer, u64 route, u32 port, 
	return res.err;

}



int tb_cfg_write(struct tb_ctl *ctl, void *buffer, u64 route, u32 port,

int tb_cfg_write(struct tb_ctl *ctl, const void *buffer, u64 route, u32 port,

		 enum tb_cfg_space space, u32 offset, u32 length)

{

	struct tb_cfg_result res = tb_cfg_write_raw(ctl, buffer, route, port,

drivers/thunderbolt/ctl.h

+2 −2
Original line number Diff line number Diff line
@@ -61,13 +61,13 @@ struct tb_cfg_result tb_cfg_read_raw(struct tb_ctl *ctl, void *buffer, 
				     u64 route, u32 port,

				     enum tb_cfg_space space, u32 offset,

				     u32 length, int timeout_msec);

struct tb_cfg_result tb_cfg_write_raw(struct tb_ctl *ctl, void *buffer,

struct tb_cfg_result tb_cfg_write_raw(struct tb_ctl *ctl, const void *buffer,

				      u64 route, u32 port,

				      enum tb_cfg_space space, u32 offset,

				      u32 length, int timeout_msec);

int tb_cfg_read(struct tb_ctl *ctl, void *buffer, u64 route, u32 port,

		enum tb_cfg_space space, u32 offset, u32 length);

int tb_cfg_write(struct tb_ctl *ctl, void *buffer, u64 route, u32 port,

int tb_cfg_write(struct tb_ctl *ctl, const void *buffer, u64 route, u32 port,

		 enum tb_cfg_space space, u32 offset, u32 length);

int tb_cfg_get_upstream_port(struct tb_ctl *ctl, u64 route);

drivers/thunderbolt/tb.h

+1 −1
Original line number Diff line number Diff line
@@ -173,7 +173,7 @@ static inline int tb_port_read(struct tb_port *port, void *buffer, 
			   length);

}



static inline int tb_port_write(struct tb_port *port, void *buffer,

static inline int tb_port_write(struct tb_port *port, const void *buffer,

				enum tb_cfg_space space, u32 offset, u32 length)

{

	return tb_cfg_write(port->sw->tb->ctl,