Commit 169cc4c7 authored Aug 06, 2018 by Peter Rosin Committed by Andrzej Hajda Sep 13, 2018

drm: bridge: document bridge attach/detach imbalance



Since commit 4a878c03 ("drm: bridge: Detach bridge from encoder at
encoder cleanup time"), it is generally no longer correct to detach bridges
from encoders manually. Document that.

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180806061910.29914-3-peda@axentia.se

parent eb1d23d7

drivers/gpu/drm/drm_bridge.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -104,6 +104,10 @@ EXPORT_SYMBOL(drm_bridge_remove);
		* If non-NULL the previous bridge must be already attached by a call to this
		* function.
		*
		* Note that bridges attached to encoders are auto-detached during encoder
		* cleanup in drm_encoder_cleanup(), so drm_bridge_attach() should generally
		* not be balanced with a drm_bridge_detach() in driver code.
		*
		* RETURNS:
		* Zero on success, error code on failure
		*/