Commit 16853d7b authored Jul 22, 2014 by Markus Pargmann Committed by Greg Kroah-Hartman Jul 22, 2014

usb: ci_hdrc_imx: Return -EINVAL for missing USB PHY



-ENODEV is interpreted by the generic driver probing function as a
non-matching driver. This leads to a missing probe failure message.

Also a missing USB PHY is more of an invalid configuration of the usb
driver because it is necessary.

This patch returns -EINVAL if devm_usb_get_phy_by_phandle() returned -ENODEV.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9672f0fe

drivers/usb/chipidea/ci_hdrc_imx.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -133,6 +133,9 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
		data->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "fsl,usbphy", 0);
		if (IS_ERR(data->phy)) {
		ret = PTR_ERR(data->phy);
		/* Return -EINVAL if no usbphy is available */
		if (ret == -ENODEV)
		ret = -EINVAL;
		goto err_clk;
		}