Commit 166f0adf authored Dec 14, 2021 by Hangyu Hua Committed by Greg Kroah-Hartman Dec 22, 2021

rds: memory leak in __rds_conn_create()



[ Upstream commit 5f9562ebe710c307adc5f666bf1a2162ee7977c0 ]

__rds_conn_create() did not release conn->c_path when loop_trans != 0 and
trans->t_prefer_loopback != 0 and is_outgoing == 0.

Fixes: aced3ce57cd3 ("RDS tcp loopback connection can hang")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9cb405ee

net/rds/connection.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -253,6 +253,7 @@ static struct rds_connection __rds_conn_create(struct net net,
		* should end up here, but if it
		* does, reset/destroy the connection.
		*/
		kfree(conn->c_path);
		kmem_cache_free(rds_conn_slab, conn);
		conn = ERR_PTR(-EOPNOTSUPP);
		goto out;