Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 166e0d4d authored by Aleksandr Burakov's avatar Aleksandr Burakov Committed by Greg Kroah-Hartman
Browse files

media: ngene: Add dvb_ca_en50221_init return value check 



[ Upstream commit 9bb1fd7eddcab2d28cfc11eb20f1029154dac718 ]

The return value of dvb_ca_en50221_init() is not checked here that may
cause undefined behavior in case of nonzero value return.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 25aee3de ("[media] Rename media/dvb as media/pci")
Signed-off-by: default avatarAleksandr Burakov <a.burakov@rosalinux.ru>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 472e95f2

drivers/media/pci/ngene/ngene-core.c

+3 −1
Original line number Diff line number Diff line
@@ -1488,7 +1488,9 @@ static int init_channel(struct ngene_channel *chan) 
	}



	if (dev->ci.en && (io & NGENE_IO_TSOUT)) {

		dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1);

		ret = dvb_ca_en50221_init(adapter, dev->ci.en, 0, 1);

		if (ret != 0)

			goto err;

		set_transfer(chan, 1);

		chan->dev->channel[2].DataFormatFlags = DF_SWAP32;

		set_transfer(&chan->dev->channel[2], 1);