Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1664691a authored by Chris Wilson's avatar Chris Wilson
Browse files

drm: Use default dma_fence hooks where possible for null syncobj 



Both the .enable_signaling and .release of the null syncobj fence
can be replaced by the default callbacks for a small reduction in code
size. In particular the default callback for .release was changed in
commit e28bd101 ("drm: rename null fence to stub fence in syncobj v2")
which neglected its RCU protection.

Fixes: e28bd101 ("drm: rename null fence to stub fence in syncobj v2")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180920200530.2836-1-chris@chris-wilson.co.uk


Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent adbc8208

drivers/gpu/drm/drm_syncobj.c

+0 −11
Original line number Diff line number Diff line
@@ -66,20 +66,9 @@ static const char *drm_syncobj_stub_fence_get_name(struct dma_fence *fence) 
        return "syncobjstub";

}



static bool drm_syncobj_stub_fence_enable_signaling(struct dma_fence *fence)

{

    return !dma_fence_is_signaled(fence);

}



static void drm_syncobj_stub_fence_release(struct dma_fence *f)

{

	kfree(f);

}

static const struct dma_fence_ops drm_syncobj_stub_fence_ops = {

	.get_driver_name = drm_syncobj_stub_fence_get_name,

	.get_timeline_name = drm_syncobj_stub_fence_get_name,

	.enable_signaling = drm_syncobj_stub_fence_enable_signaling,

	.release = drm_syncobj_stub_fence_release,

};