Commit 15f63b74 authored Dec 18, 2013 by Kumar Sanghvi Committed by David S. Miller Dec 22, 2013

cxgb4: Account for stid entries properly in case of IPv6

IPv6 uses 2 TIDs with CLIP enabled and 4 TIDs without CLIP.
Currently we are incrementing STIDs in use by 1 for both IPv4 and IPv6 which
is wrong.

Further, driver currently does not have interface to query if CLIP is programmed
for particular IPv6 address. So, in this patch we increment/decrement TIDs in use
by 4 for IPv6 assuming absence of CLIP. Such assumption keeps us on safe side and
we don't end up allocating more stids for IPv6 than actually supported.

Based on original work by Santosh Rastapur <santosh@chelsio.com>

Signed-off-by: Kumar Sanghvi <kumaras@chelsio.com>
Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 470c60c4

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -2986,7 +2986,14 @@ int cxgb4_alloc_stid(struct tid_info t, int family, void data)
		if (stid >= 0) {
		t->stid_tab[stid].data = data;
		stid += t->stid_base;
		/* IPv6 requires max of 520 bits or 16 cells in TCAM
		* This is equivalent to 4 TIDs. With CLIP enabled it
		* needs 2 TIDs.
		*/
		if (family == PF_INET)
		t->stids_in_use++;
		else
		t->stids_in_use += 4;
		}
		spin_unlock_bh(&t->stid_lock);
		return stid;
		@@ -3039,7 +3046,10 @@ void cxgb4_free_stid(struct tid_info *t, unsigned int stid, int family)
		else
		bitmap_release_region(t->stid_bmap, stid, 2);
		t->stid_tab[stid].data = NULL;
		if (family == PF_INET)
		t->stids_in_use--;
		else
		t->stids_in_use -= 4;
		spin_unlock_bh(&t->stid_lock);
		}
		EXPORT_SYMBOL(cxgb4_free_stid);