Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15cb127e authored by Gustavo Pimentel's avatar Gustavo Pimentel Committed by Lorenzo Pieralisi
Browse files

PCI: dwc: Fix MSI-X EP framework address calculation bug 



Fix an error caused by 3-bit right rotation on offset address
calculation of MSI-X table in dw_pcie_ep_raise_msix_irq().

The initial testing code was setting by default the offset address of
MSI-X table to zero, so that even with a 3-bit right rotation the
computed result would still be zero and valid, therefore this bug went
unnoticed.

Fixes: beb4641a ("PCI: dwc: Add MSI-X callbacks handler")
Signed-off-by: default avatarGustavo Pimentel <gustavo.pimentel@synopsys.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
parent c6fd6fe9

drivers/pci/controller/dwc/pcie-designware-ep.c

+0 −1
Original line number Diff line number Diff line
@@ -440,7 +440,6 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, 
	tbl_offset = dw_pcie_readl_dbi(pci, reg);

	bir = (tbl_offset & PCI_MSIX_TABLE_BIR);

	tbl_offset &= PCI_MSIX_TABLE_OFFSET;

	tbl_offset >>= 3;



	reg = PCI_BASE_ADDRESS_0 + (4 * bir);

	bar_addr_upper = 0;