Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1575c083 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

tty: serial: 8250_mtk: Fix potential NULL pointer dereference 



There is a potential NULL pointer dereference in case devm_kzalloc()
fails and returns NULL.

Fix this by adding a NULL check on data->dma

This bug was detected with the help of Coccinelle.

Fixes: 85b5c1dd ("serial: 8250-mtk: add uart DMA support")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f17b5f06

drivers/tty/serial/8250/8250_mtk.c

+3 −0
Original line number Diff line number Diff line
@@ -357,6 +357,9 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p, 
	if (dmacnt == 2) {

		data->dma = devm_kzalloc(&pdev->dev, sizeof(*data->dma),

					 GFP_KERNEL);

		if (!data->dma)

			return -ENOMEM;



		data->dma->fn = mtk8250_dma_filter;

		data->dma->rx_size = MTK_UART_RX_SIZE;

		data->dma->rxconf.src_maxburst = MTK_UART_RX_TRIGGER;