Commit 152b8616 authored Jan 12, 2012 by Julia Lawall Committed by David Woodhouse Mar 27, 2012

mtd: onenand: samsung: add missing iounmap

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent 335a5f40

drivers/mtd/onenand/samsung.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -923,7 +923,7 @@ static int s3c_onenand_probe(struct platform_device *pdev)
		r = platform_get_resource(pdev, IORESOURCE_MEM, 1);
		if (!r) {
		dev_err(&pdev->dev, "no buffer memory resource defined\n");
		return -ENOENT;
		err = -ENOENT;
		goto ahb_resource_failed;
		}

		@@ -964,7 +964,7 @@ static int s3c_onenand_probe(struct platform_device *pdev)
		r = platform_get_resource(pdev, IORESOURCE_MEM, 1);
		if (!r) {
		dev_err(&pdev->dev, "no dma memory resource defined\n");
		return -ENOENT;
		err = -ENOENT;
		goto dma_resource_failed;
		}