Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 151f72f4 authored by Colin Ian King's avatar Colin Ian King Committed by Philipp Zabel
Browse files

reset: fix null pointer dereference on dev by dev_name 



The call to dev_name will dereference dev, however, dev is later
being null checked, so there is a possibility of a null pointer
dereference on dev by the call to dev_name. Fix this by null
checking dev first before the call to dev_name

Detected by CoverityScan, CID#1475475 ("Dereference before null check")

Fixes: 2a6cb2b1d83b ("reset: Add reset_control_get_count()")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent eaf91db0

drivers/reset/core.c

+2 −1
Original line number Diff line number Diff line
@@ -799,12 +799,13 @@ EXPORT_SYMBOL_GPL(devm_reset_control_array_get); 
static int reset_control_get_count_from_lookup(struct device *dev)

{

	const struct reset_control_lookup *lookup;

	const char *dev_id = dev_name(dev);

	const char *dev_id;

	int count = 0;



	if (!dev)

		return -EINVAL;



	dev_id = dev_name(dev);

	mutex_lock(&reset_lookup_mutex);



	list_for_each_entry(lookup, &reset_lookup_list, list) {