Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1504ecbe authored by Peter Huewe's avatar Peter Huewe Committed by Greg Kroah-Hartman
Browse files

staging/xgifb: Don't write the same values x times 



With the previous patch 'Move duplicated code for dram to helper
function' it becomes evident that the code is performing the same
thing 4 or 8 times in a row without changing arguments to the function
and thus writing the same values over and over again.

It was tested that these repeats are unnecessary.

-> we can safely remove them.

Tested-by: default avatarAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0141bb2e

drivers/staging/xgifb/vb_init.c

+6 −13
Original line number Diff line number Diff line
@@ -439,25 +439,18 @@ static void XGINew_SetDRAMDefaultRegister340( 
	xgifb_reg_set(P3d4, 0x69, pVBInfo->CR40[6][pVBInfo->ram_type]);

	xgifb_reg_set(P3d4, 0x6A, pVBInfo->CR40[7][pVBInfo->ram_type]);



	for (i = 0; i < 4; i++) {

	/* CR6B DQS fine tune delay */

	temp = (pVBInfo->ram_type <= 2) ? 0xaa : 0x00;

	XGI_SetDRAM_Helper(P3d4, temp, 0, 0x6B, 2, 0xF0, 0x10);

	}



	for (i = 0; i < 4; i++) {

	/* CR6E DQM fine tune delay */

	XGI_SetDRAM_Helper(P3d4, 0, 0, 0x6E, 2, 0xF0, 0x10);

	}



	temp3 = 0;

	for (k = 0; k < 4; k++) {

		/* CR6E_D[1:0] select channel */

		xgifb_reg_and_or(P3d4, 0x6E, 0xFC, temp3);

		for (i = 0; i < 8; i++) {

			/* CR6F DQ fine tune delay */

		XGI_SetDRAM_Helper(P3d4, 0, 0, 0x6F, 0, 0xF8, 0x08);

		}

		temp3 += 0x01;

	}