Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14fa91e0 authored by Alaa Hleihel's avatar Alaa Hleihel Committed by Jason Gunthorpe
Browse files

IB/ipoib: Do not warn if IPoIB debugfs doesn't exist 



netdev_wait_allrefs() could rebroadcast NETDEV_UNREGISTER event
multiple times until all refs are gone, which will result in calling
ipoib_delete_debug_files multiple times and printing a warning.

Remove the WARN_ONCE since checks of NULL pointers before calling
debugfs_remove are not needed.

Fixes: 771a5258 ("IB/IPoIB: ibX: failed to create mcg debug file")
Signed-off-by: default avatarAlaa Hleihel <alaa@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Reviewed-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 7928b2cb

drivers/infiniband/ulp/ipoib/ipoib_fs.c

+0 −2
Original line number Diff line number Diff line
@@ -281,8 +281,6 @@ void ipoib_delete_debug_files(struct net_device *dev) 
{

	struct ipoib_dev_priv *priv = ipoib_priv(dev);



	WARN_ONCE(!priv->mcg_dentry, "null mcg debug file\n");

	WARN_ONCE(!priv->path_dentry, "null path debug file\n");

	debugfs_remove(priv->mcg_dentry);

	debugfs_remove(priv->path_dentry);

	priv->mcg_dentry = priv->path_dentry = NULL;